Refactor builder & changelog in to pkg #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves builder in to it's own public package. Additionally the builder package has also been refactored. The previous builder pattern has been dropped in favour of a standard options pattern. Also methods have been broken down as much as possible with the hope that it will increase readability and help reduce duplication in the future. Tests have also been updated, along with mocks, to reflect the new structure.
This commit moves changelog in to it's own public package. The code remains largely untouched. However imports and tests have been updated, along with mocks, to reflect the changes.
This commit rewires the writer package so that it can see the new changelog package.
This commit rewires the new command so that it properly imports builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves builder in to it's own public package. Additionally the builder package has also been refactored.
The previous builder pattern has been dropped in favour of a standard options pattern.
Also methods have been broken down as much as possible with the hope that it will increase readability and help reduce duplication in the future.
Additionally, changelog has also been moved in to it's own public package. The code remains largely untouched.
Tests have also been updated, along with mocks, to reflect the new structure.