Simplify config printing #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reading an article about unit testing stdout, it became clear that using bufio for this specific case was overkill. os.Stdout actually implements the writer interface, therefore it's possible to pass it straight in to the methods and switch out writer.Write for fmt.Fprint.
chelnak
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading an article about unit testing stdout, it became clear that using
bufiofor this specific case was overkill. os.Stdout actually implements the writer interface, therefore it's possible to pass it straight in to the methods and switch outwriter.Writeforfmt.Fprint.Closes #67