Support rate limits and missing performance data #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its normal for some tests (eg paused, failed etc) to not have any performance data
chelnak
approved these changes
Mar 5, 2024
|
Looks great, thank you |
|
Great, thanks. Any chance of a release too @chelnak? I have a bit of time to get this tested with the new metrics today |
|
Hey, v1.1.1 should be available in a few minutes 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #13 , the statuscake API is pretty quick to rate limit requests. This checks the HTTP response code and adds a delay where required. Note that I have only implemented this on the performance-related endpoint for now, I had no issues being rate limited on the other endpoints.
It also includes a change to ignore performance data being absent for some tests - its normal for things like failed/paused tests to not have this field.