feat: improve 1D line broadening filter #3260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jobo322
commented
Oct 7, 2024
•
jobo322
commented
- Change of filter format towards 2D processing #3261
- add shape property to peaks added manually
jobo322
changed the title
Deploying nmrium with
|
| Latest commit: |
dba0fc6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef5a74f0.nmrium.pages.dev |
| Branch Preview URL: | https://2931-crash-at-the-moment-to.nmrium.pages.dev |
jobo322
force-pushed
the
2931-crash-at-the-moment-to-show-peak-shapes-of-peaks-from-manual-peak-picking
branch
2 times, most recently
from
c829aa4
to
39978a8
Compare
hamed-musallam
force-pushed
the
2931-crash-at-the-moment-to-show-peak-shapes-of-peaks-from-manual-peak-picking
branch
from
0f22b19
to
3095c77
Compare
hamed-musallam
changed the title
This was
linked to
issues
Oct 22, 2024
|
First conflict should be solved and then I don't know which issue is solved with this PR. |
hamed-musallam
force-pushed
the
2931-crash-at-the-moment-to-show-peak-shapes-of-peaks-from-manual-peak-picking
branch
from
4e1f589
to
63998a3
Compare
hamed-musallam
force-pushed
the
2931-crash-at-the-moment-to-show-peak-shapes-of-peaks-from-manual-peak-picking
branch
from
d9bf3f0
to
8984793
Compare
lpatiny
reviewed
Oct 31, 2024
Co-authored-by: Luc Patiny <lpatiny@users.noreply.github.com>
|
@targos @lpatiny, optional parameters does not exist anymore in filters. In nmrium there is a conflict in the onLoadProcessing: -https://github.com/cheminfo/nmrium/blob/main/src/demo/views/SnapshotView.tsx#L428-L433 I propose do not use the same type of Filters, then at the moment to apply the filters we could completed the options needed |
|
@jobo322 Did you check why the testcases are not passing ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.