Add "full" gelu without approximation #209
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gelu_noapprox
which calculates the full gelu (pytorch default case, see here).Context: I have implemented a thermodynamic model based on a ChemBERTa model here. To obtain the same results (within numerical accuracy) as the original model (which was implemented using pytorch, see here), the "full" gelu activation function is needed (locally tested). So I would be happy to have this feature added in Transformers.jl, so that I can submit the corresponding changes to Clapeyron.jl.