Skip to content

Commit

Permalink
[receiver/opencensus] Do not report error message on clean shutdown (o…
Browse files Browse the repository at this point in the history
…pen-telemetry#36622)

#### Description
The receiver is reporting error on a clean shutdown because it is not
looking for the correct error. Besides logging a false-positive error
message this can end up in a deadlock during shutdown due to
open-telemetry/opentelemetry-collector#9824

#### Testing

Added a test specific for that. In principle, this should be part of the
generated tests, but, to do that it will be necessary to add support to
the `Reporter` interface.

#### Documentation

Changelog.
  • Loading branch information
pjanotti authored and chengchuanpeng committed Jan 26, 2025
1 parent f17cebb commit f48fd50
Showing 1 changed file with 27 additions and 0 deletions.
27 changes: 27 additions & 0 deletions .chloggen/opencensus_receiver_no_error_msg_on_clean_shutdown.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: opencensusreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Do not report error message when OpenCensus receiver is shutdown cleanly.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [36622]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]

0 comments on commit f48fd50

Please sign in to comment.