CSS class names are a function of the style object #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32.
I used
sha1
to mirror the way we've done this in the past, but I think that we should replace it with either a fast, non-cryptographically secure hash (like murmur), or even a checksum algorithm (like Adler-32--which React uses to compare client- and server-side markup (granted, collisions there are less important than they are here)--or CRC32). Thoughts?Another thing to note: before, if we'd already seen
styleObj
in the global registry, we didn't return anything, which isn't really expected behaviour. Now, we return a style object regardless of whether or not it's in the registry (with a shallow clone).