Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException when try to add null foreign record fix #677

Merged
merged 2 commits into from
Nov 9, 2016
Merged

NullPointerException when try to add null foreign record fix #677

merged 2 commits into from
Nov 9, 2016

Conversation

bioker
Copy link
Contributor

@bioker bioker commented Sep 28, 2016

Hello, i hope this fix will be useful for resolving that issue

@mention-bot
Copy link

@bioker, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jivimberg, @JonatanSalas and @sibelius to be potential reviewers

@JonatanSalas
Copy link
Collaborator

I will take a look at this when I get to home! Thank you for your PR!

@sibelius
Copy link
Contributor

Could u fix the tests?

@bioker
Copy link
Contributor Author

bioker commented Sep 29, 2016

@sibelius, yes i could, what exactly need? Using empty constructor?

@bioker
Copy link
Contributor Author

bioker commented Sep 29, 2016

@sibelius, Ok. I look at the details of the check fail. Just I didn't before requests, don't understood at first time

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 74.825% when pulling d057a0c on bioker:master into ca5dd14 on satyan:master.

@taynanbonaldo
Copy link

Hi, is it possible to use a version of the library with this problem fixed?

@sibelius sibelius merged commit f7f6b05 into chennaione:master Nov 9, 2016
@sibelius
Copy link
Contributor

sibelius commented Nov 9, 2016

looks good, tks

@taynanbonaldo
Copy link

taynanbonaldo commented Nov 9, 2016

@sibelius Thank you so much, but has any beta release that can I use? Or only cloning project and using it as an module?

@sibelius
Copy link
Contributor

sibelius commented Nov 9, 2016

@taynanb u just use master version for now: https://github.com/satyan/sugar#how-to-use-master-version

@taynanbonaldo
Copy link

@sibelius Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants