Manually init classes list #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RossinesP, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JonatanSalas, @sibelius and @whoshuu to be potential reviewers. |
added 2 commits
November 3, 2016 11:23
|
Just a heads up. getModelsClassesList() isn't called anywhere. I had to modify SugarApp.onCreate() to use the list accepting version of SugarContext.init() to get this to work with the method over ride. It works fine manually calling the init method though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initialization, SugarOrm parses all the classes in a specified package and finds all SugarRecord classes. This has been problematic in the past because of InstantRun and newest Gradle build tools.
This commit adds a way to manually declare the list of classes we want to convert to tables.
Simply provide a list of Class objects when calling SugarContext.init() or extend SugarApp and its getModelsClassesList() method.
All of this is obviously optional.
Note that no test and no example app has been written for this modification.