Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated lifecycle #109

Conversation

KevinHurts
Copy link

Starting from React 17 componentWillUpdate will be deprecated.
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

@andreyluiz
Copy link

Guys, we are using this library and it saves a serious amount of work when rendering Lottie files.

Can you give some attention to this PR, please?

@stephenway
Copy link

stephenway commented Aug 13, 2020

Wanted to chime in here to share what I'm doing to get around the issue currently. Using patch-package to copy over the compiled dist/index.js (from this branch) over to node_modules/react-lottie to generate a patch that gets injected pre-install. Would be nice though if we could get this PR merged soon since React 17 has a release candidate now.

@silver-snoopy
Copy link

It would be nice, if this PR could be merged. Many thanks for the PR @KevinHurts 💯

@KevinHurts
Copy link
Author

Since this repo is not actively maintained anymore I closed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants