peerDependencies : react^17.0.0 #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been using this package for quite a while with react@17.0.2 and it works fine with it. thus extending peerDep for the same since we usually get conflicting peerDep issue ``` Could not resolve dependency: npm ERR! peer react@"^0.14.7 || ^15.0.0 || ^16.0.0" from react-lottie@1.2.3 npm ERR! node_modules/react-lottie npm ERR! react-lottie@"^1.2.3" from the root project Found: react@17.0.2 ``` Please review, merge and deploy on npm if you find it useful.
|
I think this can now also be extended to react@18 |
|
@chenqingspring any chance we could merges and react^18.0.0 change? encountering same issue |
|
As a workaround for future readers: i patched locally using |
|
Just use this: which is on a fork. |
|
set "react": ">=15.0.0" to fix this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using this package for quite a while with react@17.0.2 and it works fine with it. thus extending peerDep for the same since we usually get conflicting peerDep issue
Please review, merge and deploy on npm if you find it useful.