Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call information #3

Closed
Savaturkey opened this issue May 21, 2022 · 4 comments
Closed

call information #3

Savaturkey opened this issue May 21, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Savaturkey
Copy link

Savaturkey commented May 21, 2022

Your program is beautiful. It will be very nice to find the caller information, timestamp, who called and incoming or outgoing call information on the file name where the call is saved.

@chenxiaolong
Copy link
Owner

Thanks!

The filename should already include the timestamp and phone number. The format currently looks like this:

<date>_<time><timezone>_<phone number>.flac

Eg.

20220522_122802.881926-0400_+12345678900.flac

I'll see if I can add in or out to the filename to distinguish between incoming and outgoing calls.

@Savaturkey
Copy link
Author

Savaturkey commented May 22, 2022

The name of the caller or the person being called is also very important. I don't think the timezone matters.

chenxiaolong added a commit that referenced this issue May 22, 2022
This only works on Android 10+.

Issue: #3
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong added a commit that referenced this issue May 22, 2022
This only works on Android 10+.

Issue: #3
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong added a commit that referenced this issue May 22, 2022
With this change, the timestamps in the filenames will match the
timestamps in Android's call log exactly.

Issue: #3
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong added a commit that referenced this issue May 22, 2022
This is based on CNAP only and does not perform lookups against the
user's contacts. Note that only the initial CNAP value at the time the
call becomes active is used. CNAP changes are ignored.

Issue: #3
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong added a commit that referenced this issue May 22, 2022
…calls

This is based on CNAP only and does not perform lookups against the
user's contacts. Note that only the initial CNAP value at the time the
call becomes active is used. CNAP changes are ignored.

Issue: #3
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
chenxiaolong added a commit that referenced this issue May 22, 2022
…calls

This is based on CNAP only and does not perform lookups against the
user's contacts. Note that only the initial CNAP value at the time the
call becomes active is used. CNAP changes are ignored.

Issue: #3
Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
@chenxiaolong chenxiaolong self-assigned this May 22, 2022
@chenxiaolong
Copy link
Owner

I implemented some of the suggestions in #11, #12, and #13.

  • The filenames now include in or out on Android 10+. The API does not exist on Android 9.

  • Incoming calls will now include the caller name in the filename. This is based on the CNAP value (caller ID) at the time that the call is answered. If you have a third party caller ID app that's slow and updates after the call is answered, the filename will not reflect the updated caller ID.

    Also, BCR will not look up names in the contact database. I currently do not plan on implementing any features that require the contacts permission.

  • The timestamps in the filenames now match the dialer's call log exactly. It represents the time that Android registered the incoming/outgoing call instead of the time that the recording began.

The output formats are now:

# Incoming calls (Android 10+)
<date>_<time><timezone offset>_in_<phone number>_<caller ID>.flac

# Incoming calls (Android 9)
<date>_<time><timezone offset>_<phone number>_<caller ID>.flac

# Outgoing calls (Android 10+)
<date>_<time><timezone offset>_out_<phone number>.flac

# Outgoing calls (Android 9)
<date>_<time><timezone offset>_<phone number>.flac

(I'm keeping the timezone offset in the filename because it's the only way to distinguish timestamps across DST boundaries when the time jumps backwards.)

@Dusk-Golem
Copy link

Dusk-Golem commented May 22, 2022

I implemented some of the suggestions in #11, #12, and #13.

  • The filenames now include in or out on Android 10+. The API does not exist on Android 9.
  • Incoming calls will now include the caller name in the filename. This is based on the CNAP value (caller ID) at the time that the call is answered. If you have a third party caller ID app that's slow and updates after the call is answered, the filename will not reflect the updated caller ID.
    Also, BCR will not look up names in the contact database. I currently do not plan on implementing any features that require the contacts permission.
  • The timestamps in the filenames now match the dialer's call log exactly. It represents the time that Android registered the incoming/outgoing call instead of the time that the recording began.

The output formats are now:

# Incoming calls (Android 10+)
<date>_<time><timezone offset>_in_<phone number>_<caller ID>.flac

# Incoming calls (Android 9)
<date>_<time><timezone offset>_<phone number>_<caller ID>.flac

# Outgoing calls (Android 10+)
<date>_<time><timezone offset>_out_<phone number>.flac

# Outgoing calls (Android 9)
<date>_<time><timezone offset>_<phone number>.flac

(I'm keeping the timezone offset in the filename because it's the only way to distinguish timestamps across DST boundaries when the time jumps backwards.)

For android 9, may be rearrange the naming sequence for in/out differentiation, for example, for incoming calls name the file using the current scheme and for outgoing calls, bring the number to the front of the filename like;

<phone number>_date>_<time><timezone offset>.flac

Anyways, not a big deal if you leave it as is. Also, thank you for adding android 9 support...

@chenxiaolong chenxiaolong added the enhancement New feature or request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants