Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Record rules Unable to select simcard for recording #649

Closed
GitRadeth opened this issue Jan 2, 2025 · 10 comments · Fixed by #652
Closed

Auto-Record rules Unable to select simcard for recording #649

GitRadeth opened this issue Jan 2, 2025 · 10 comments · Fixed by #652
Assignees
Labels
bug/limitation elsewhere Bug/limitation in the ROM or another project

Comments

@GitRadeth
Copy link

Thank you for implementing the feature!
However i have an issue with the feature.

Version 1.75
Phone: CPH2493
Android: OxygenOS 14 (CPH2493_14.0.0.560(EX01))

shared image

@chenxiaolong
Copy link
Owner

Hmm, in your recordings, does _sim1/_sim2 show up in the filename?

@GitRadeth
Copy link
Author

GitRadeth commented Jan 3, 2025

recording
It does not appear so.
Edit, i just checked the filenames and it in the format: +areacode number-(example, 2501030804).mp3
Edit 2:
In the application folder com.chiller3.bcr i get the files in a different format: date_time+timezone_direction_+areacodetelephonenumber.oga

@chenxiaolong
Copy link
Owner

Hmm, can you try enabling the "write metadata file" option and then make a call? It should create a .json file in your output directory. If you open the file, does it list the correct SIM slot at the top? For example:

{
    "timestamp_unix_ms": 1731947273741,
    "timestamp": "2024-11-18T11:27:53.741-05:00",
    "direction": "out",
    "sim_slot": 1,
...

Also, can you double check that BCR has the "phone" permission? It is required for BCR to be able to see the SIM slot.

@GitRadeth
Copy link
Author

GitRadeth commented Jan 3, 2025

20250103_154506.535+0100_IN_29000.json
I just called myself.
shared image (1)
The app does have the phone permission.

Also, to verify that the phone has two slots :)
shared image (2)

@chenxiaolong
Copy link
Owner

Thanks! I downloaded the ROM you're running (CPH2493_14.0.0.560) and unfortunately, it looks like this feature won't be able to work on your device.

Although dual SIM is supported, the stock ROM does not support Android's internal android.hardware.telephony.subscription feature. This makes it impossible for apps like BCR to find out which SIM a call is associated with.

@chenxiaolong chenxiaolong self-assigned this Jan 3, 2025
@chenxiaolong chenxiaolong added the bug/limitation elsewhere Bug/limitation in the ROM or another project label Jan 3, 2025
@GitRadeth
Copy link
Author

Ok, thanks anyway! Keep up the good work :)

@chenxiaolong
Copy link
Owner

Actually, could you give this test build a try? BCR-1.75.r4.g090280e-release.zip

OxygenOS doesn't declare support for android.hardware.telephony.subscription, but maybe it's supported anyway. This test build removes BCR's check and tries to access the SIM slot information even if Android claims it's not supported.

@chenxiaolong chenxiaolong reopened this Jan 4, 2025
@GitRadeth
Copy link
Author

GitRadeth commented Jan 4, 2025

I do not have the option to make a sharp test as it is way into the night here. However i tried calling from one sim to the other, and the json file actually seem to recognize the simcard now! However i cannot test the potential fix until tomorrow :)

20250104_012817.486+0100_OUT_sim1_0733882631.json

Edit, i also see the option in the rules now to specify the sim card for recording.
Screenshot_2025-01-04-01-37-17-00_88a63a93497fdafe6b6f2215ec875412

Edit #2 i will return with confirmation tomorrow :)

@GitRadeth
Copy link
Author

Update:
The fix seems to work flawlessly i made a rule to only record on simcard 2 and set the default rule to ignore.
It does only record on simcard 2 and not on simcard 1 as intended.

Thank you for taking the time to help me, it is much appreciated!

Have a nice weekend!

@chenxiaolong
Copy link
Owner

Awesome, glad it's working! The fix will be included in the upcoming 1.76 release. In the meantime, feel free to continue using the test build. (There's no downside to doing so.)

Hope you have a great weekend as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/limitation elsewhere Bug/limitation in the ROM or another project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants