Target SDK 32 instead of the Tiramisu preview #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out apps built with the preview SDK cannot be installed on older stable versions of Android. With BCR now targeting SDK 32, the creation of the notification channel has been moved from RecorderInCallService to RecorderApplication to ensure that Android 13 Beta devices automatically prompt for notification permissions on the first app launch. Once the stable SDK 33 is released, we can re-add the runtime permissions request for POST_NOTIFICATIONS. Fixes: #1 Signed-off-by: Andrew Gunnerson <chillermillerlong@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out apps built with the preview SDK cannot be installed on
older stable versions of Android.
With BCR now targeting SDK 32, the creation of the notification channel
has been moved from RecorderInCallService to RecorderApplication to
ensure that Android 13 Beta devices automatically prompt for
notification permissions on the first app launch.
Once the stable SDK 33 is released, we can re-add the runtime
permissions request for POST_NOTIFICATIONS.
Fixes: #1