magisk: Try to install to a non-overlayfs location #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magisk currently has a known issue where its mirror mount points do not work correctly with overlayfs. Files from the overlayfs lowerdirs may no longer be accessible. On MIUI, this is a problem because /system/etc/permissions is an overlayfs mount and one of the lowerdirs is /product/pango/system/etc/permissions. One file underneath that path is com.nxp.nfc.nq.xml, which if missing, breaks NFC. Fixes: #242 Fixes: #246 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
|
This will be fixed properly by topjohnwu/Magisk#6588 on the Magisk side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magisk currently has a known issue where its mirror mount points do not work correctly with overlayfs. Files from the overlayfs lowerdirs may no longer be accessible.
On MIUI, this is a problem because /system/etc/permissions is an overlayfs mount and one of the lowerdirs is
/product/pango/system/etc/permissions. One file underneath that path is com.nxp.nfc.nq.xml, which if missing, breaks NFC.
Fixes: #242
Fixes: #246