-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Latvian (LV) translation #515
base: master
Are you sure you want to change the base?
Conversation
Latvian language added
Thanks for the PR! Can you also add Lines 121 to 137 in 05dfcbc
BCR/app/src/main/res/xml/locales_config.xml Lines 2 to 18 in 05dfcbc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the two lists. The build seems to have failed due to a missing translation in a <plurals>
block. I've left a comment on it below.
<string name="output_dir_bottom_sheet_file_retention">Failu saglabāšana</string> | ||
<string name="output_dir_bottom_sheet_edit_retention">Rediģēt glabāšanas iestatījumus</string> | ||
<string name="retention_keep_all">Saglabāt visus</string> | ||
<plurals name="retention_days"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Android requires an <item quantity="zero">
option for Latvian:
/home/runner/work/BCR/BCR/app/src/main/res/values-lv/strings.xml:53: Error: For locale "lv" (Latvian) the following quantity should also be defined: zero (e.g. "0 diennakšu") [MissingQuantity]
@osering do you plan to fix the patch? |
No description provided.