Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Latvian (LV) translation #515

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

osering
Copy link

@osering osering commented Mar 14, 2024

No description provided.

@chenxiaolong
Copy link
Owner

Thanks for the PR! Can you also add lv to the lists in these two files? This is required for Android 13's per-app language feature to work.

BCR/app/build.gradle.kts

Lines 121 to 137 in 05dfcbc

resourceConfigurations.addAll(listOf(
"de",
"en",
"es",
"fr",
"hi",
"it",
"iw",
"pl",
"pt-rPT",
"ru",
"sk",
"tr",
"uk",
"zh-rCN",
"zh-rTW",
))

<locale-config xmlns:android="http://schemas.android.com/apk/res/android">
<locale android:name="de" />
<locale android:name="en" />
<locale android:name="es" />
<locale android:name="fr" />
<locale android:name="hi" />
<locale android:name="it" />
<locale android:name="iw" />
<locale android:name="pl" />
<locale android:name="pt-rPT" />
<locale android:name="ru" />
<locale android:name="sk" />
<locale android:name="tr" />
<locale android:name="uk" />
<locale android:name="zh-rCN" />
<locale android:name="zh-rTW" />
</locale-config>

Copy link
Owner

@chenxiaolong chenxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the two lists. The build seems to have failed due to a missing translation in a <plurals> block. I've left a comment on it below.

<string name="output_dir_bottom_sheet_file_retention">Failu saglabāšana</string>
<string name="output_dir_bottom_sheet_edit_retention">Rediģēt glabāšanas iestatījumus</string>
<string name="retention_keep_all">Saglabāt visus</string>
<plurals name="retention_days">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Android requires an <item quantity="zero"> option for Latvian:

  /home/runner/work/BCR/BCR/app/src/main/res/values-lv/strings.xml:53: Error: For locale "lv" (Latvian) the following quantity should also be defined: zero (e.g. "0 diennakšu") [MissingQuantity]

@NBruderman
Copy link

@osering do you plan to fix the patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants