Add support for specifying a minimum recording duration #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the recording isn't long enough, it will be discarded at the end of the call. The duration is computed based on the recording duration (number of encoded frames), not the call duration, so it excludes regions where the user explicitly paused the recording and regions where the call was placed on hold. Similar to the record rules, this can be overridden during the call from BCR's notification. Fixes: #411 Fixes: #604 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
|
Test build: BCR-1.71.r2.ge5fe6ce-release.zip |
This was referenced Sep 20, 2024
chenxiaolong
added a commit
that referenced
this pull request
Sep 22, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the recording isn't long enough, it will be discarded at the end of the call. The duration is computed based on the recording duration (number of encoded frames), not the call duration, so it excludes regions where the user explicitly paused the recording and regions where the call was placed on hold.
Similar to the record rules, this can be overridden during the call from BCR's notification.
Fixes: #411
Fixes: #604