Manually handle audio/mp4 file extension in older versions of Android #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 9 and 10 support a much smaller list of MIME types because they hadn't migrated to the mime-support package yet (used by most Linux distros). With this commit, BCR will explicitly append the file extension for audio/mp4 when saving to local storage. Other document providers don't get this special treatment because there is no way to determine which MIME types they support. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 9 and 10 support a much smaller list of MIME types because they hadn't migrated to the mime-support package yet (used by most Linux distros). With this commit, BCR will explicitly append the file extension for
audio/mp4when saving to local storage. Other document providers don't get this special treatment because there is no way to determine which MIME types they support.