Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS review] Add spherical indexing system #24

Closed
chenyangkang opened this issue Jan 17, 2024 · 1 comment
Closed

[JOSS review] Add spherical indexing system #24

chenyangkang opened this issue Jan 17, 2024 · 1 comment
Labels
enhancement New feature or request JOSS review Solve issues during JOSS review

Comments

@chenyangkang
Copy link
Owner

This issue is to solve the problem suggested by [at]jedalong (openjournals/joss-reviews#6158)

I think it is probably associated with the tools used for modelling that do not expect spatial objects, but binning the data correctly based on spatial objects and then back transforming to the expected data structure migth be a more correct way to deal with the spherical geometry issue.

TODO:

  1. Implement spherical indexing system
@chenyangkang chenyangkang added enhancement New feature or request JOSS review Solve issues during JOSS review labels Jan 17, 2024
@chenyangkang chenyangkang moved this to Backlog in JOSS review 2 Jan 17, 2024
@chenyangkang chenyangkang moved this from Backlog to Ready in JOSS review 2 Jan 17, 2024
@chenyangkang chenyangkang moved this from Ready to In progress in JOSS review 2 Jan 18, 2024
chenyangkang added a commit that referenced this issue Jan 24, 2024
@chenyangkang
Merge pull request #34 from chenyangkang/chenyangkang-JOSS-review
7436f33 
SphereAdaSTEM modules and make mini test

Mainly solve #24

Final consideration for #30 – Not using geo-object due to speed limitation.
@chenyangkang
Copy link
Owner Author

Closing with #34

@github-project-automation github-project-automation bot moved this from In progress to Done in JOSS review 2 Jan 24, 2024
@chenyangkang chenyangkang mentioned this issue Jan 26, 2024
Closed
chenyangkang added a commit that referenced this issue Sep 20, 2024
@chenyangkang
Merge pull request #34 from chenyangkang/chenyangkang-JOSS-review
9621442 
SphereAdaSTEM modules and make mini test

Mainly solve #24

Final consideration for #30 – Not using geo-object due to speed limitation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request JOSS review Solve issues during JOSS review
Projects
No open projects
JOSS review 2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chenyangkang