Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Integrate feemarket + reworked ante, post handler decorator distinction #782

Merged
merged 38 commits into from
Sep 20, 2024
Merged

feat: Integrate feemarket + reworked ante, post handler decorator distinction #782

merged 38 commits into from
Sep 20, 2024

Conversation

vishal-kanna
Copy link
Collaborator

closes: #777

Eengineer1
Eengineer1 requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's adjust the antehandler to route transactions based on the aforementioned remarks + restore the indicative unit tests.

Posthandler looks closer to completion.

ante/fee.go Outdated Show resolved Hide resolved
ante/fee_test.go Show resolved Hide resolved
Eengineer1
Eengineer1 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishal-kanna Could you please remove comments + temporarily disable upgrade tests preparing the PR for a final review?

There exists indicative helptext to guide you where to disable the test runs from.

@Eengineer1 Eengineer1 changed the title chore: updated ante and post handler feat: updated ante and post handler Sep 5, 2024
@Eengineer1 Eengineer1 changed the title feat: updated ante and post handler feat: Reworked ante, post handler decorator distinction Sep 5, 2024
@vishal-kanna vishal-kanna marked this pull request as ready for review September 6, 2024 04:56
@Eengineer1 Eengineer1 mentioned this pull request Sep 9, 2024
Closed
Eengineer1
Eengineer1 requested changes Sep 9, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
ante/fee_test.go Show resolved Hide resolved
tests/integration/cli/config.go Outdated Show resolved Hide resolved
tests/integration/helpers/fee.go Outdated Show resolved Hide resolved
@vishal-kanna vishal-kanna changed the title feat: Reworked ante, post handler decorator distinction feat: Integrate FeeMarket ,Reworked ante,post handler decorator distinction Sep 12, 2024
@Eengineer1 Eengineer1 changed the title feat: Integrate FeeMarket ,Reworked ante,post handler decorator distinction feat: Integrate feemarket + reworked ante, post handler decorator distinction Sep 12, 2024
Eengineer1
Eengineer1 requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core work looks good.

Please address the remarks before merging the work into develop + synchronising across the various dependent PRs, such as the fee-abstraction integration.

ante/fee_test.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
tests/integration/cli/config.go Show resolved Hide resolved
@Eengineer1 Eengineer1 mentioned this pull request Sep 18, 2024
Merged
Eengineer1
Eengineer1 previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standalone work looks well polished.

Approved.

Eengineer1
Eengineer1 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with increased gas adjustment for consistency purposes.

@Eengineer1 Eengineer1 merged commit 0486022 into develop Sep 20, 2024
16 of 17 checks passed
@Eengineer1 Eengineer1 deleted the vishal/integrate-antehandler branch September 20, 2024 13:58
Eengineer1 added a commit that referenced this pull request Sep 20, 2024
@Eengineer1
Revert "feat: Integrate feemarket + reworked ante, post handler decor…
77508cf 
…ator distinction (#782)"

This reverts commit 0486022.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 approved these changes

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishal-kanna @Eengineer1