fix: Return DidResolutionResult in resource_query_handler #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't his have some updated tests? |
@sownak This part of the code is never called. It will be called if we did not register DidDocQueryHandlers. we don't have any unittests for query handlers |
ankurdotb
added a commit
that referenced
this pull request
Feb 21, 2025
…+ other fixes [DEV-4758] (#340) * feat: Accept contetType params for DID URL Resolution * Update tests * Add additional tests * Get highest priority header and params * Add additional tests * Add additional tests * feat: Render json and text in ResourceWithMetadata * fix: Add custom json marshaller * fix linting errors * feat: Return metadata in contentMetadata key * Update integration tests * feat: new headers for didDoc resolution Signed-off-by: Sownak Roy <sownak@cheqd.io> * fix: lint errors Signed-off-by: Sownak Roy <sownak@cheqd.io> * Use go-accept-headers * Updated integration tests Signed-off-by: Sownak Roy <sownak@cheqd.io> * Revert to contentPriorityType * feat: Support metadata=false && resourceMetadata with W3DIDRes header * updated GetPriorityContentType Signed-off-by: Sownak Roy <sownak@cheqd.io> * fix default resource profile * Empty commit for triggering deployment/fix * fix resourceMetadata Signed-off-by: Sownak Roy <sownak@cheqd.io> * fixed browser errors Signed-off-by: Sownak Roy <sownak@cheqd.io> * updated dependabot changes Signed-off-by: Sownak Roy <sownak@cheqd.io> * added testcases Signed-off-by: Sownak Roy <sownak@cheqd.io> * Added Chrome test cases Signed-off-by: Sownak Roy <sownak@cheqd.io> * npm update * make swagger * Updated with review comments Signed-off-by: Sownak Roy <sownak@cheqd.io> * Updated with review comments Signed-off-by: Sownak Roy <sownak@cheqd.io> * Updated with review comments Signed-off-by: Sownak Roy <sownak@cheqd.io> * merged from develop * fixed lint errors Signed-off-by: Sownak Roy <sownak@cheqd.io> * Bump to final API release version * Update resource query handlers to support resolution * fix linting errors * fix: Return DidResolutionResult in resource_query_handler (#341) * Support jsonld didurlDereferencing in queries * Update .gitignore * gofumpt --------- Signed-off-by: Sownak Roy <sownak@cheqd.io> Co-authored-by: Ankur Banerjee <ankurdotb@users.noreply.github.com> Co-authored-by: Tasos Derisiotis <50984242+Eengineer1@users.noreply.github.com> Co-authored-by: Sownak Roy <sownak@cheqd.io> Co-authored-by: Sownak Roy <20537268+sownak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously resource query handlers pass only the resources in response. we are return didDoc + metadata to support didResolution in queries. This part of code which will be called only if DidDocQueryHandlers are not registered was missing this change