Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to install files using Pip #519

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

E-M-Bailey
Copy link
Contributor

fixes #518

This adds a new run script, run-pip.sh, which uses Pip instead of Poetry to install dependencies. It also modifies the README with appropriate instructions.

Copy link
Collaborator

@algmyr algmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for not getting to this for a bit. Added a comment about making the venv usage (which I like) common among the script and configurable. Should be a pretty minor change, I hope you don't mind. :)

run-pip.sh Show resolved Hide resolved
@algmyr
Copy link
Collaborator

algmyr commented Jan 26, 2024

I guess I could make that change myself in a follow-up.

@algmyr algmyr merged commit d7821e6 into cheran-senthil:master Jan 26, 2024
@E-M-Bailey
Copy link
Contributor Author

Sorry, I missed your original response. I'm happy to try making the changes myself sometime this weekend, although I don't have a good way of testing the non-Pip version.

@algmyr
Copy link
Collaborator

algmyr commented Jan 26, 2024

Sorry, I missed your original response. I'm happy to try making the changes myself sometime this weekend, although I don't have a good way of testing the non-Pip version.

No worries, I made the changes already in #520. You'll have to make a change locally to add an environment variable but that should be about it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation is broken on some systems
2 participants