Storybook #6
Merged
Storybook #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for Tailwind CSS to show up in Storybook, a few changes needed to be made: - postcss.config.mjs needed to be renamed to postcss.config.js so that Storybook could find it - tailwind.config.ts needed to be updated to include the path to Storybook's stories folder - I tested the changes by updating the Button component with a Tailwind color and running `npm run storybook` to check that the component was styled correctly
✅ Deploy Preview for uncloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Will check the "Chromatic Publish / test (push)" in the morning. |
|
Ok! Looks like deployment is all good now. I had followed the instructions in Storybook's documentation, but it appears they're outdated. The instructions on Chromatic (where the Storybook will be deployed) worked. Note, that I've also added our chromatic project token as a Github repository token. |
Add link to published Storybook.
GinaCastromonte
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Related Issue
N/A
Related Story Card
N/A
Type of Changes
Dependency update
Acceptance Criteria
N/A
Testing Instructions
npm run storybook, and check the button component: it should be blue (via the Tailwind CSS class)