-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating UI and behavior after registering #7
Conversation
✅ Deploy Preview for uncloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all the testing and acceptance criteria and it all checks out. The only thing I think we need to come back to later is that, when you refresh as a logged in user, the logged out state flashes for long enough that a user could interpret it as an error. It does keep the user logged in, though; it's just a brief flash (which Jenny points out in the PR notes).
I can add the components to Storybook, with updated styling to match the new wireframe! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The functionality worked according to the Jira needs. I did notice as well the state management is a little buggy when page is refreshed. I will take the task of fixing our auth/state management so that we can move on to the next sprint.
Description
Updates to behavior and UI after user registration:
Related Issue
https://cherryontech-jupiter-jumpers.atlassian.net/browse/SCRUM-12
https://cherryontech-jupiter-jumpers.atlassian.net/browse/SCRUM-13
Related Story Card
Provide a link to the relevant story card.
Type of Changes
Feature update.
Acceptance Criteria
Update Screenshots
Before
This was the view pre and post authentication
After
Modal appears after first authentication
UI reflects logged in state
Testing Instructions
Learnings (Optional)
Document any things you learned or 'gotchas' you experienced.