Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating UI and behavior after registering #7

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

jtkabenni
Copy link
Collaborator

@jtkabenni jtkabenni commented Apr 26, 2024

Description

Updates to behavior and UI after user registration:

  • redirected to home page after account created
  • Welcome message modal appears after user authenticates for the first time (creating account)
  • Modal does not appear again after it is closed out
  • user context created so logged in user information is global
  • firebase API functions for user added to new api file
  • new field closedConfirmationMessage added to DB to track whether user has closed message or not

Related Issue

https://cherryontech-jupiter-jumpers.atlassian.net/browse/SCRUM-12
https://cherryontech-jupiter-jumpers.atlassian.net/browse/SCRUM-13

Related Story Card

Provide a link to the relevant story card.

Type of Changes

Feature update.

Acceptance Criteria

  • User is taken to home page after creating account
  • The confirmation modal appears after creating account
  • The user can click 'get started' to close out the modal
  • After refreshing, the user remains logged in
  • The confirmation modal does not appear again after it is closed

Update Screenshots

Before

This was the view pre and post authentication
Screenshot 2024-04-27 at 5 22 44 PM

After

Modal appears after first authentication
Screenshot 2024-04-27 at 5 13 38 PM

UI reflects logged in state
Screenshot 2024-04-27 at 5 13 46 PM

Testing Instructions

  1. Create an account
  2. Make sure app directs you to home page (/)
  3. View confirmation message modal
  4. Close out modal
  5. Make sure app reflects logged in state
  6. Refresh to make sure you remain logged in (this takes a second so the logged out state will flash initially)

Learnings (Optional)

Document any things you learned or 'gotchas' you experienced.

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for uncloud ready!

Name Link
🔨 Latest commit 14bcff6
🔍 Latest deploy log https://app.netlify.com/sites/uncloud/deploys/662d78c155bede0008025023
😎 Deploy Preview https://deploy-preview-7--uncloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jtkabenni
Copy link
Collaborator Author

To do:

  • styling to match design, but wanted to see if storybook UI would impact this?
  • wrote some files in js and need to convert to ts

Copy link
Collaborator

@paola4 paola4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the testing and acceptance criteria and it all checks out. The only thing I think we need to come back to later is that, when you refresh as a logged in user, the logged out state flashes for long enough that a user could interpret it as an error. It does keep the user logged in, though; it's just a brief flash (which Jenny points out in the PR notes).

@paola4
Copy link
Collaborator

paola4 commented Apr 28, 2024

To do:

* styling to match design, but wanted to see if storybook UI would impact this?

* wrote some files in js and need to convert to ts

I can add the components to Storybook, with updated styling to match the new wireframe!

Copy link
Collaborator

@GinaCastromonte GinaCastromonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The functionality worked according to the Jira needs. I did notice as well the state management is a little buggy when page is refreshed. I will take the task of fixing our auth/state management so that we can move on to the next sprint.

@GinaCastromonte GinaCastromonte merged commit 3ff52ec into main Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants