Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles (LinkedIn Resources) #12

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Articles (LinkedIn Resources) #12

merged 9 commits into from
Nov 29, 2023

Conversation

PelumiTayo
Copy link
Collaborator

Description

Static Page for Resources

What Changes Did I Make?

  • Added Articles folder that uses JSON file to show information about the resources related to LinkedIn

Change Type

  • Bug Fix
  • New Feature
  • Code Refactor
  • Documentation
  • Other

Related Issue

To Review

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for peachykeen-jobquest ready!

Name Link
🔨 Latest commit 6ad54df
🔍 Latest deploy log https://app.netlify.com/sites/peachykeen-jobquest/deploys/6566662bc0636200073d29db
😎 Deploy Preview https://deploy-preview-12--peachykeen-jobquest.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@khairahscorner khairahscorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Nicely done @PelumiTayo

An extra layer you might want to add to the component files for both Article and TaskCard is a useEffect that checks whether the user is logged in before allowing access to the route, else it redirects them to say, the login page.

This will prevent scenarios of users having access to those pages if they directly enter the URL but are not actually logged in.

So something like this:

useEffect(() => {
if (!localStorage.getItem("jobQuestEmail")) {
      navigateTo("/login");
    }
}, [])

The access restrictions are usually added in the file where the routes are defined but we only have a few routes, so this may be simpler to use.

@khairahscorner khairahscorner merged commit 9b80aa1 into main Nov 29, 2023
4 checks passed
@khairahscorner khairahscorner deleted the articles branch November 29, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants