-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Articles (LinkedIn Resources) #12
Conversation
✅ Deploy Preview for peachykeen-jobquest ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Nicely done @PelumiTayo
An extra layer you might want to add to the component files for both Article
and TaskCard
is a useEffect
that checks whether the user is logged in before allowing access to the route, else it redirects them to say, the login page.
This will prevent scenarios of users having access to those pages if they directly enter the URL but are not actually logged in.
So something like this:
useEffect(() => {
if (!localStorage.getItem("jobQuestEmail")) {
navigateTo("/login");
}
}, [])
The access restrictions are usually added in the file where the routes are defined but we only have a few routes, so this may be simpler to use.
Description
Static Page for Resources
What Changes Did I Make?
Change Type
Related Issue
To Review