-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: roadmap page structure + styling #7
Conversation
✅ Deploy Preview for peachykeen-jobquest ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use nextui properly now with the recent push!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @PmS-crypto
I've done a new review, left some comments and suggested changes for you to commit.
I would also encourage you to keep your CSS files lean by using the utility classes already provided by tailwindcss
to style your components instead of writing them all over again in your stylesheets (see comment I left in two of the css files). After the program, you can take some time to familiarise yourself with the classes Tailwindcss provides
|
||
export const LandingPage = () => { | ||
const navigateTo = useNavigate() | ||
|
||
return ( | ||
<div className="landing-page"> | ||
<div className="div"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This navbar needs to be separated into a component, so that it can be used across all pages e.g the roadmap page. It also needs to be updated to include the log in/sign up buttons and log out button (for logged in users), as shown in the designs
I would need you to make the corrections as soon as you can so that this branch can be merged to main, because it is already diverging again from the main branch @PmS-crypto |
Description
The text alignment in the landing page is updated.
The roadmap page is given a clear structure.
Next UI is installed.
What Changes Did I Make?
css properties' values are updated.
In the latest commit, I have installed nextui in our project (https://nextui.org/docs/guide/installation).
Also, I have utilized nextui's card component - https://nextui.org/docs/components/card; however I am facing styling errors therein.
Change Type
Related Issue
To Review