fix: linter accepts all forms of foreach range #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated positional parser to accespt range specification
* updated foreach range keyword to use new range spec
* add PyCharm files to .gitignore
* mtepfer sign contributor agreement
closes #256
Person-93
force-pushed
the
master
branch
3 times, most recently
from
f179735
to
a0f0b54
Compare
|
I added a commit to fix a security vulnerability, but I forgot that I'd used this branch for a pull request. If you re-run the CI job it should pass like it did before. |
jayvdb
reviewed
Jul 26, 2021
| @@ -342,6 +342,7 @@ def parse2(cls, ctx, tokens, spec, breakstack): | |||
| * "?": zero or one | |||
| * "*": zero or more | |||
| * "+": one or more | |||
| * "min-max": where min is the minimum pargs count and max is the maximum pargs count | |||
There was a problem hiding this comment.
I think CI is failing because this line is too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #256