Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#25] Add putty v3 support. Get the code working on py3. #56

Merged
merged 41 commits into from
Mar 26, 2024

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Mar 21, 2023

Scope

Fixes #25
Fixes #54

This is to help with the migration of chevah/server to py3

It started as support for both py2 and py3, but we should merge this will all tests passing and with only support for py3.

Changes

Move the package to a non-namespace.
Modernize the project build with the code in src and with setup.cfg

How to try and test the changes

reviewers: @danuker

More of a FYI.

Most of the code is tested in chevah/server

We have a big tech-debt here and we need to rewrite the tests...

or redesing the project/code so that the low-level sign/verify is used directly from Twisted, without replication

And chevah-keycert will only handle the serialization/deserialization of various SSH keys.

There is also the idea of moving all this code into the python-cryptography code, as that project already has basic support for OpeSSH key format.

and chevah-keycert uses cryptography for low-level operations

@adiroiban adiroiban changed the title [#25] Get the code working on py2 and py3. [#25] Get the code working on py3. Mar 12, 2024
@adiroiban adiroiban closed this Mar 12, 2024
@adiroiban adiroiban reopened this Mar 12, 2024
@adiroiban adiroiban closed this Mar 13, 2024
@adiroiban adiroiban reopened this Mar 13, 2024
@adiroiban
Copy link
Member Author

Dan, this is ready for review.
I plan to integrate the code in chevah/server to get support for Putty v3

SOme of the code from here is already used in chevah/server ... but I didn't had time to release chevah-keycert

Now, with the test passing, I think this is ready to merge.

The putty v3 code is a lot of copy paste... but we can improve that in a separate ticket

needs-review

@adiroiban
Copy link
Member Author

@danuker it looks like this repo is not handled by chevah-robot ?

@adiroiban
Copy link
Member Author

I am merging this as the code is in used https://github.com/chevah/server/pull/6632

for any issues we can open a new PR

@adiroiban adiroiban merged commit 04cba86 into master Mar 26, 2024
9 checks passed
@adiroiban adiroiban changed the title [#25] Get the code working on py3. [#25] Add putty v3 support. Get the code working on py3. Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Putty v3 key file format Port to py3
1 participant