Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #27 #31

Closed
rodber opened this issue Oct 7, 2023 · 0 comments
Closed

Revert #27 #31

rodber opened this issue Oct 7, 2023 · 0 comments
Milestone

Comments

@rodber
Copy link
Member

rodber commented Oct 7, 2023

By using action names instead of objects the design complicates dependencies as it will require a container for this purpose.

Shared dependencies should be passed using variables/references as that's the moto of this lib: Reusable actions and workflows.

Action dependencies (constructor arguments) should be provided on Workflow declaration layer. Don't use container.

rodber added a commit that referenced this issue Oct 17, 2023
@rodber rodber closed this as completed Oct 17, 2023
@rodber rodber added this to the 0.9.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant