support all of unified JVM logging decorations #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
awesomefly
Apr 26, 2023
|
Hi
Thank you very much for your contribution! It looks good.
Would you have time to add some more unittests for the method
DataReaderUnifiedJvmLogging#createGcEventWithStandardDecorators()? It
has quite a lot of ifs that have no unittest to make sure, the logic
will not break during future refactorings.
Best regards
Jörg
|
Hi, I have added more unit tests, and now the unit tests can cover the new logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found the latest code only supports the specific decorations for unified JVM logging. If other decorations are configured (e.g.
-Xlog:safepoint=trace,class*=info,age*=trace,gc*=info,gc+heap=trace:file=../gclogs/gc.log:time,pid,tid,level,tags:filecount=0), the app would fail to load the logs. I modified the relevant code to support all decorations. Additionally, I make theGCEventcan getting the time from any one decoration.Furthermore, I find if the app load the log which contains oom logs, a large number of warning messages would be printed. I think the app should ignore it, so I add this tag to the exclude list.