Skip to content

Commit

Permalink
scsi: ufs: core: No need to update UPIU.header.flags and lun in advan…
Browse files Browse the repository at this point in the history
…ced RPMB handler

For advanced RPMB requests, its UPIU package should be fully initialized in
its ufs-bsg-based application, except for task tag. in ufshcd.c, we just
copy UPIU (with CDB) request as-is.

Signed-off-by: Bean Huo <beanhuo@micron.com>
Link: https://lore.kernel.org/r/20230809181847.102123-3-beanhuo@iokpp.de
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
beanhuo authored and martinkpetersen committed Aug 31, 2023
1 parent c91e585 commit 9f6fec6
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/ufs/core/ufshcd.c
Original file line number Diff line number Diff line change
@@ -7250,9 +7250,7 @@ int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *r
else
ufshcd_prepare_req_desc_hdr(lrbp, &upiu_flags, dir, 0);

/* update the task tag and LUN in the request upiu */
req_upiu->header.flags = upiu_flags;
req_upiu->header.lun = UFS_UPIU_RPMB_WLUN;
/* update the task tag */
req_upiu->header.task_tag = tag;

/* copy the UPIU(contains CDB) request as it is */

0 comments on commit 9f6fec6

Please sign in to comment.