-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework and extend endian-specific conversion API #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
========================================
Coverage ? 65.1%
========================================
Files ? 8
Lines ? 1410
Branches ? 156
========================================
Hits ? 918
Misses ? 444
Partials ? 48 |
axic
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the API is fine (more readable than before), haven't reviewed the code though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105.
This reworks and extends mostly the
intx::be
API for converting to/from bytes in big-endian order.The usage is shown in https://github.com/ethereum/evmone/pull/131/files.
After prototyping the usage of new API, I propose further changes:
uint<N>
toload<uint<N>>
. In the end it is more consistent so seebe::load<uint256>(...)
instead ofbe::uint<256>
and would allow to support other types likebe::load<int256>
.uint_unsafe()
tounsafe_load()
orunsafe::load()
. The later would allow hiding the "unsafe" mark withusing namespace intx::be::unsafe
.store_unsafe()
tounsafe_store()
orunsafe::store()
.