Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add arm64 build #255

Merged
merged 3 commits into from
Mar 9, 2022
+14 −4
Merged

ci: Add arm64 build #255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ba11af
ci: Add arm64 build
chfast Mar 8, 2022
a9f2777
test: Fix build on archs other than x86_64
chfast Mar 9, 2022
efb2c54
test: Correct is_constant_evaluated() expectations
chfast Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions circle.yml
View file
Original file line number Diff line number Diff line change
@@ -195,6 +195,15 @@ jobs:
- build_and_test
- benchmark

arm64:
environment:
BUILD_TYPE: Release
machine:
image: ubuntu-2004:202101-01
resource_class: arm.medium
steps:
- build_and_test

no-exceptions:
environment:
BUILD_TYPE: Release
@@ -289,3 +298,4 @@ workflows:
- fuzzing
- macos
- cmake-min
- arm64
6 changes: 3 additions & 3 deletions test/benchmarks/bench_div.cpp
View file
Original file line number Diff line number Diff line change
@@ -52,11 +52,11 @@ inline uint64_t reciprocal_naive(uint64_t d) noexcept
const auto u = uint128{~uint64_t{0}, ~d};
uint64_t v;

#if _MSC_VER
v = (u / d).lo;
#else
#if __x86_64__
uint64_t _;
asm("divq %4" : "=d"(_), "=a"(v) : "d"(u[1]), "a"(u[0]), "g"(d));
#else
v = (u / d)[0];
#endif

return v;
2 changes: 1 addition & 1 deletion test/unittests/test_builtins.cpp
View file
Original file line number Diff line number Diff line change
@@ -132,7 +132,7 @@ TEST(builtins, is_constant_evaluated)
auto is_constexpr_false = is_constant_evaluated();
auto nonconstexpr_func_res = func();

#if (defined(__clang__) && __clang_major__ >= 9) || (defined(__GNUC__) && __GNUC__ >= 9) || \
#if (defined(__clang__) && __clang_major__ >= 9) || (defined(__GNUC__) && __GNUC__ >= 10) || \
(defined(_MSC_VER) && _MSC_VER >= 1925)
EXPECT_FALSE(is_constexpr_false);
EXPECT_EQ(nonconstexpr_func_res, 2);