feat: add OData Version to options #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chgeo did you have a chance to take a look? I think the tests are failing are unrelated to my change. |
chgeo
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I found an issue when using @cds-dk version 7.2.0 or later in my project.
@cds-dk offers the parameter
odata-versionwhich, if left blank, defaults to '4.01'. However if your OData service is still on version 4.0 (which should be the case for most projects), OData functions would will not be compiled correctly. Odata functions can be called without parentheses in OData version 4.01 but not in 4.0.This PR adds an the
odataVersionparameter to the options, so that projects can specify which OData version should be used for the OpenAPI compilation.Feel free to suggest any changes.
Kind regards,
Yannick