Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an out of bounds crash #94

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

joeljfischer
Copy link
Contributor

Description

  • When parsing version bytes and the index is out of bounds a crash would occur

Motivation and Context

Fixes a crash

How Has This Been Tested?

Tested with a broken file that was crashing the app

Types of changes

  • Bug fix 🐛 (non-breaking change which fixes an issue)
  • New feature ✨ (non-breaking change which adds functionality)
  • Breaking change 💥 (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project 🍻.
  • My change requires a change to the documentation 💡 and I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document 👥.
  • I have added tests to cover my changes 🎉.
  • All new and existing tests passed ✅.

* When version bytes are out of bounds a crash would occur
@chicio
Copy link
Owner

chicio commented Nov 13, 2022

Hi @joeljfischer, thank you so much for the contribution. Seems fine to me. Probably in the future we can trigger an error instead of returning a default wrong version in the ID3TagVersionParser. Anyway it is ok. Going to merge now and release a new patch version.

PS please support my work by starring this repository ⭐️ Thank you again.

@chicio chicio merged commit 7297a74 into chicio:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants