Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix truncated build issues in vscode #99

Merged

Conversation

wlsnmrk
Copy link
Contributor

@wlsnmrk wlsnmrk commented Oct 16, 2024

In VSCode (on Windows 11, with .NET 8), build issues are displayed in the "Problems" tab with truncated filenames and messages:
Screenshot 2024-10-15 150634

In addition, clicking the issue attempts to open the displayed (incorrect) filename:
Screenshot 2024-10-15 150646

Screenshot 2024-10-15 150653


The issue appears to be that VSCode's problem matcher can't handle line wrapping in the terminal output of the build task (see this C# extension issue and this VSCode issue):
Screenshot 2024-10-15 214106


This PR modifies the build task to pass the /consoleloggerparameters:ForceNoAlign option to dotnet build, recommended as a workaround in the above issues. This option prevents the terminal output from wrapping, and causes build issues to appear as expected:
Screenshot 2024-10-15 214043

Fixed an issue with build issue filenames and messages being truncated
in VS Code by passing the /consoleloggerparameters:ForceNoAlign option
to dotnet build.
@jolexxa jolexxa merged commit 0b290c0 into chickensoft-games:main Oct 16, 2024
2 checks passed
@wlsnmrk wlsnmrk deleted the fix-truncated-vscode-build-problems branch October 16, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants