Adding translation for Yes/No buttons (#811)

chidiwilliams · Jun 22, 2024 · 2d5684c · 2d5684c
1 parent 9894760
commit 2d5684c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/buzz/locale/lv_LV/LC_MESSAGES/buzz.po b/buzz/locale/lv_LV/LC_MESSAGES/buzz.po
@@ -451,7 +451,7 @@ msgstr "Lejupielādē modeli"
 
 #: buzz/widgets/model_download_progress_dialog.py:37
 msgid "remaining"
-msgstr "!"
+msgstr "..."
 
 #: buzz/widgets/menu_bar.py:38
 msgid "Import File..."

diff --git a/buzz/widgets/main_window.py b/buzz/widgets/main_window.py
@@ -219,14 +219,23 @@ def on_clear_history_action_triggered(self):
         if len(selected_rows) == 0:
             return
 
-        reply = QMessageBox.question(
-            self,
-            _("Clear History"),
+        question_box = QMessageBox()
+        question_box.setWindowTitle(_("Clear History"))
+        question_box.setIcon(QMessageBox.Icon.Question)
+        question_box.setText(
             _(
                 "Are you sure you want to delete the selected transcription(s)? "
                 "This action cannot be undone."
             ),
         )
+        question_box.setStandardButtons(
+            QMessageBox.StandardButton.Yes | QMessageBox.StandardButton.No
+        )
+        question_box.button(QMessageBox.StandardButton.Yes).setText(_("Ok"))
+        question_box.button(QMessageBox.StandardButton.No).setText(_("Cancel"))
+
+        reply = question_box.exec()
+
         if reply == QMessageBox.StandardButton.Yes:
             self.table_widget.delete_transcriptions(selected_rows)
 

diff --git a/tests/widgets/main_window_test.py b/tests/widgets/main_window_test.py
@@ -162,7 +162,7 @@ def test_should_clear_history_with_rows_selected(
         table_widget = self._get_tasks_table(window)
         table_widget.selectAll()
 
-        with patch("PyQt6.QtWidgets.QMessageBox.question") as question_message_box_mock:
+        with patch("PyQt6.QtWidgets.QMessageBox.exec") as question_message_box_mock:
             question_message_box_mock.return_value = QMessageBox.StandardButton.Yes
             window.toolbar.clear_history_action.trigger()