Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue with parentSelector when using a barren parent. #272

Merged
merged 2 commits into from
Feb 19, 2016

Conversation

jklaus
Copy link
Contributor

@jklaus jklaus commented Feb 8, 2016

I have modified the $animate.enter() associated with the bar and spinner resolving the issue related to using a childless parent.

@chieffancypants
Copy link
Owner

Isn't .last() a jquery method? I don't see it listed in the available jqlite methods

@jklaus
Copy link
Contributor Author

jklaus commented Feb 19, 2016

@chieffancypants, I honestly forgot to verify that it was implemented in jqlite.. kind of surprised it isn't given how basic that functionality is. Guess I need to drop my jQuery reference next time I'm bug-fixing.

Modified logic to remove $.last() usage.
@chieffancypants
Copy link
Owner

Great, thanks!

chieffancypants added a commit that referenced this pull request Feb 19, 2016
Resolved issue with parentSelector when using a barren parent.
@chieffancypants chieffancypants merged commit de74337 into chieffancypants:master Feb 19, 2016
@chieffancypants chieffancypants added this to the next version milestone Feb 19, 2016
@chieffancypants
Copy link
Owner

Shit, probably shouldn't have merged without checking tests first. Can you please fix the tests and I can do an official release?

@stefanotorresi
Copy link
Contributor

don't get me wrong, @jklaus, but isn't #244 already doing what this does, only more comprehensively and with tests?

@jklaus
Copy link
Contributor Author

jklaus commented Feb 24, 2016

@stefanotorresi, my intent wasn't to modify the overall approach.. I merely resolved the issue caused by barren parents. Not to say I wouldn't like to see a change in the approach.. but as I am not the original author I don't feel it my place to make that decision for his branch.

@jklaus
Copy link
Contributor Author

jklaus commented Feb 24, 2016

@chieffancypants I just saw your note about the tests.. it'll be a bit before I can look into that. Pushing hard on a deliverable atm.

@chieffancypants chieffancypants mentioned this pull request Mar 8, 2016
chieffancypants added a commit that referenced this pull request Mar 8, 2016
This reverts commit de74337, reversing
changes made to 531e175.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants