-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved issue with parentSelector when using a barren parent. #272
Conversation
Isn't |
@chieffancypants, I honestly forgot to verify that it was implemented in jqlite.. kind of surprised it isn't given how basic that functionality is. Guess I need to drop my jQuery reference next time I'm bug-fixing. |
Modified logic to remove $.last() usage.
Great, thanks! |
Resolved issue with parentSelector when using a barren parent.
Shit, probably shouldn't have merged without checking tests first. Can you please fix the tests and I can do an official release? |
@stefanotorresi, my intent wasn't to modify the overall approach.. I merely resolved the issue caused by barren parents. Not to say I wouldn't like to see a change in the approach.. but as I am not the original author I don't feel it my place to make that decision for his branch. |
@chieffancypants I just saw your note about the tests.. it'll be a bit before I can look into that. Pushing hard on a deliverable atm. |
I have modified the $animate.enter() associated with the bar and spinner resolving the issue related to using a childless parent.