This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Reduce distributed files in the gem #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igas
commented
Apr 1, 2021
| @@ -22,10 +22,16 @@ Gem::Specification.new do |spec| | |||
| spec.metadata["changelog_uri"] = "https://github.com/chiefpansancolt/simplecov-material/blob/master/CHANGELOG.md" | |||
| spec.metadata["bug_tracker_uri"] = "https://github.com/chiefpansancolt/simplecov-material/issues" | |||
|
|
|||
| spec.files = `git ls-files`.split("\n") | |||
| spec.bindir = "bin" | |||
| spec.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") | |||
igas
commented
Apr 1, 2021
| spec.files = `git ls-files`.split("\n") | ||
| spec.bindir = "bin" | ||
| spec.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") | ||
| spec.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) } |
There was a problem hiding this comment.
igas
force-pushed
the
minimise-shipped-files
branch
from
9186b30
to
f2c67e8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I reduced the files distributed with the gem, in particular executables, it's a development scripts, they got put into the user $PATH and also conflict with other gems that I plan to send similar PRs too.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
rake buildcd pkgtar xf simplecov-material-1.0.0.gemdata.tar.gzlsand made sure only relevant files thereChecklist: