Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overscroll of ui-grid horizontally when vertical scrollbar is visible. #423

Closed
dting opened this issue Apr 12, 2016 · 1 comment
Closed

Overscroll of ui-grid horizontally when vertical scrollbar is visible. #423

dting opened this issue Apr 12, 2016 · 1 comment
Labels
bug wontfix

Comments

@dting
Copy link
Member

dting commented Apr 12, 2016

screen shot 2016-04-12 at 12 32 48 am
screen shot 2016-04-12 at 12 33 06 am

Whenever the vertical scrollbar appear the horizontal scrollbar becomes scrollable, even when the specified widths are less than the viewable region. This seems to be a bug that was fixed and reappeared in the ui-grid library:
angular-ui/ui-grid#2734

When looking at the files in the merged PR in the current release, Subtracting the scrollbar width is has been commented out.

It is also mentioned here:
angular-ui/ui-grid#2635

We should keep an eye on this but having the scrollbars is a much better user experience at the cost of an eye sore. Let's ignore this issue and hope newer versions of ui-grid include a fix for the problem.
dting added a commit to dting/webapp that referenced this issue Apr 12, 2016
@dting
Fix scroll bar width issue in ui-grids.
9aa1ae6 
Resolves child-first-authority-fcc-project#406.

Custom styles for the grid scrollbars that override ui-grid
style. Autohides the scrollbars when not needed and uses
!important because of the need to overrid ui-grid inline styles.

I've been investigating some issues with the scrollbars for
a while. Notes about a related bug in issue child-first-authority-fcc-project#423.
@dting dting mentioned this issue Apr 12, 2016
Merged
dting added a commit to dting/webapp that referenced this issue Apr 12, 2016
@dting
Fix scroll bar width issue in ui-grids.
1a878da 
Resolves child-first-authority-fcc-project#406.

Custom styles for the grid scrollbars that override ui-grid
style. Autohides the scrollbars when not needed and uses
!important because of the need to overrid ui-grid inline styles.

I've been investigating some issues with the scrollbars for
a while. Notes about a related bug in issue child-first-authority-fcc-project#423.
dting added a commit to dting/webapp that referenced this issue Apr 12, 2016
@dting
Fix scroll bar width issue in ui-grids.
96832ae 
Resolves child-first-authority-fcc-project#406.

Custom styles for the grid scrollbars that override ui-grid
style. Autohides the scrollbars when not needed and uses
!important because of the need to overrid ui-grid inline styles.

I've been investigating some issues with the scrollbars for
a while. Notes about a related bug in issue child-first-authority-fcc-project#423.
@dting
Copy link
Member Author

dting commented Apr 12, 2016

I think this issue is why i Initially made the scrollbars thinner. The problem with that is without pagination, the scrollbars are needed to effectively navigate the grid.

@dting dting closed this as completed Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dting