Create public API #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nx10
requested changes
Oct 4, 2023
| get(propertyName: "vertices"): Float32Array; | ||
| get(propertyName: "faces"): Uint32Array; | ||
| get(propertyName: "vertices" | "faces") { | ||
| return this[propertyName]; |
There was a problem hiding this comment.
Why do these have to be properties? Why not either public or readonly?
There was a problem hiding this comment.
I chose this because I wanted it to be readonly, but readonly also prevents private writing. This was the workaround I found towards that end; would you just make them public?
There was a problem hiding this comment.
Oh yeah seems like it's a missing language feature microsoft/TypeScript#37487
I'm fine with whatever then. Probably I would prefer just obj.getIntensity() for auto complete convenience but do what you think is best.
| get(propertyName: "colorMapName"): ColorInterpolateName; | ||
| get(propertyName: "colors"): Float32Array; | ||
| get(propertyName: "intensity" | "colorLimits" | "colorMapName" | "colors") { | ||
| return this[propertyName]; |
There was a problem hiding this comment.
See same comment chain above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is meant as a starting point to address #39. At present, it refactors the models to the set-up proposed by this issue. As there is no attribute type that allows public read-only but private writing, I've set the attributes to private but added a
getobject for read access.I consider everything in this PR to be an early draft, so feel free to modify anything.