Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples #117

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

FleetAdmiralJakob
Copy link
Collaborator

@FleetAdmiralJakob FleetAdmiralJakob commented Dec 7, 2024

Until these issues: FormidableLabs/react-live#404, FormidableLabs/react-live#403 are fixed in react-live here are some simple fixes to these annoying SyntaxErrors:
image

@childrentime
Copy link
Owner

Wow, I'm very surprised. I don't know which version suddenly had this issue.

@childrentime childrentime merged commit a1f64f7 into childrentime:main Dec 7, 2024
6 checks passed
@childrentime
Copy link
Owner

Maybe it was when I upgraded Docusaurus previously - I didn't expect this issue would occur.

@childrentime
Copy link
Owner

Thanks very much!!!

@FleetAdmiralJakob
Copy link
Collaborator Author

Maybe it was when I upgraded Docusaurus previously - I didn't expect this issue would occur.

Maybe important to mention that our react-live version is not the latest one but if I look in the changelog it doesnt seem like it adresses our issue

@FleetAdmiralJakob FleetAdmiralJakob deleted the fix-examples branch December 7, 2024 17:04
@childrentime
Copy link
Owner

The version of react-live shouldn't matter - it was added during my previous debugging but isn't actually being used. The real usage of react-live comes from @docusaurus/theme-live-codeblock - you should check the react-live version in that package.

@childrentime
Copy link
Owner

That's interesting - I discovered that this package is also using react-live 4.1.7, and coincidentally, that update to react-live was from my previous commit: FormidableLabs/react-live#389

@childrentime
Copy link
Owner

Anyway, it's strange that their own website works fine with no issues.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants