Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support concurrent safe #118

Merged
merged 2 commits into from
Dec 8, 2024
Merged

feat: support concurrent safe #118

merged 2 commits into from
Dec 8, 2024

Conversation

childrentime
Copy link
Owner

No description provided.

@childrentime
Copy link
Owner Author

@FleetAdmiralJakob Hey, if you're interested, you could take a look at this PR.

FleetAdmiralJakob
FleetAdmiralJakob approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@FleetAdmiralJakob FleetAdmiralJakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although im not a react wizard. dont see why this shouldn't work haha

packages/core/src/useDarkMode/index.ts Show resolved Hide resolved
packages/core/src/useActiveElement/index.ts Show resolved Hide resolved
packages/core/src/utils/browser.ts Show resolved Hide resolved
packages/core/src/useMouse/index.ts Show resolved Hide resolved
packages/core/src/useLatest/index.ts Show resolved Hide resolved
@childrentime childrentime merged commit 5a71524 into main Dec 8, 2024
6 checks passed
@childrentime childrentime deleted the feat/do-not-access-ref-in-render branch December 8, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FleetAdmiralJakob FleetAdmiralJakob FleetAdmiralJakob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@childrentime @FleetAdmiralJakob