Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add default font #232

Merged
merged 2 commits into from
Jan 5, 2023
Merged

[Feature] Add default font #232

merged 2 commits into from
Jan 5, 2023

Conversation

Matthiee
Copy link
Member

@Matthiee Matthiee commented Jan 4, 2023

This PR adds getDefaultFont

Related tickets

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/232/coverage.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023 •
edited
Loading

Unit Test Results

87 tests   84 ✔️  29s ⏱️
26 suites    3 💤
  1 files      0 ❌

Results for commit 245d7d8.

♻️ This comment has been updated with latest results.

@Matthiee Matthiee marked this pull request as ready for review January 4, 2023 07:44
brapoprod
brapoprod approved these changes Jan 5, 2023
View reviewed changes
src/controllers/FontController.ts Outdated Show resolved Hide resolved
@Matthiee Matthiee requested a review from brapoprod January 5, 2023 10:45
@Matthiee Matthiee merged commit f260926 into main Jan 5, 2023
@Matthiee Matthiee deleted the feature/EDT-739-get-default-font branch January 5, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brapoprod brapoprod brapoprod approved these changes

@abdelhalimkhouas abdelhalimkhouas abdelhalimkhouas approved these changes

@alexandraFlavia9 alexandraFlavia9 Awaiting requested review from alexandraFlavia9

@pietervp pietervp Awaiting requested review from pietervp

@pkgacek pkgacek Awaiting requested review from pkgacek

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matthiee @abdelhalimkhouas @brapoprod