Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Clean up connector events and states #235

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

Matthiee
Copy link
Member

This PR splits the connector states into events and states.

Related tickets

@github-actions
Copy link
Contributor

Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/235/coverage.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

Unit Test Results

89 tests   86 ✔️  26s ⏱️
27 suites    3 💤
  1 files      0

Results for commit f2276ce.

♻️ This comment has been updated with latest results.

@Matthiee Matthiee marked this pull request as ready for review January 10, 2023 14:55
pkgacek
pkgacek previously approved these changes Jan 11, 2023
@brapoprod brapoprod changed the title Clean up connector events and states [Fix] Clean up connector events and states Jan 11, 2023
@Matthiee Matthiee requested a review from Dvergar January 11, 2023 09:19
src/controllers/SubscriberController.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Dvergar Dvergar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Matthiee Matthiee merged commit 64d93e5 into main Jan 17, 2023
@Matthiee Matthiee deleted the feature/EDT-666-connector-events-and-states branch January 17, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants