Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Convert Variable into union type #245

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

Matthiee
Copy link
Member

@Matthiee Matthiee commented Feb 2, 2023

This PR converts Variable into multiple types ImageVariable, GroupVariable, ShortTextVariable, ...

This PR also corrects some other type names to better reflect what they mean.

Related tickets

Screenshots

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/245/coverage.html

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Unit Test Results

92 tests   89 ✔️  27s ⏱️
27 suites    3 💤
  1 files      0

Results for commit 1ec15e1.

♻️ This comment has been updated with latest results.

@Matthiee Matthiee marked this pull request as ready for review February 2, 2023 12:39
Copy link
Contributor

@pkgacek pkgacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@Matthiee Matthiee merged commit a6e2e2b into main Feb 6, 2023
@Matthiee Matthiee deleted the feature/EDT-611-variable-union branch February 6, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants