Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor tests #256

Merged
merged 23 commits into from
Mar 8, 2023
Merged

[Feature] Refactor tests #256

merged 23 commits into from
Mar 8, 2023

Conversation

brapoprod
Copy link
Member

@brapoprod brapoprod commented Mar 2, 2023

This PR refactors the tests to be more streamlined and consistent. Also way more safe since we test towards what is send to the EditorAPI instead of just checking if the method has been called (in a lot of cases)

Related tickets

Screenshots

@brapoprod brapoprod added the enhancement New feature or request label Mar 2, 2023
@brapoprod brapoprod self-assigned this Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/256/coverage.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Unit Test Results

    1 files    29 suites   24s ⏱️
246 tests 246 ✔️ 0 💤 0
247 runs  247 ✔️ 0 💤 0

Results for commit f8dcfdc.

♻️ This comment has been updated with latest results.

@brapoprod brapoprod changed the title [Feature] Refactor tests [WIP][Feature] Refactor tests Mar 2, 2023
@Matthiee Matthiee self-requested a review March 2, 2023 13:57
pkgacek
pkgacek previously approved these changes Mar 6, 2023
@brapoprod brapoprod changed the title [WIP][Feature] Refactor tests [Feature] Refactor tests Mar 7, 2023
NicolaVerbeeck
NicolaVerbeeck previously approved these changes Mar 7, 2023
Copy link
Member

@NicolaVerbeeck NicolaVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so-so-good

Copy link
Member

@Matthiee Matthiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left some comments where the old "Should call all of the functions of child successfully" style was still used.

Copy link
Member

@Matthiee Matthiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @brapoprod !

@brapoprod brapoprod requested a review from srares76 March 8, 2023 12:14
@brapoprod brapoprod merged commit 5dfb7bf into main Mar 8, 2023
@brapoprod brapoprod deleted the feature/refactor-tests branch March 8, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

5 participants