-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Refactor tests #256
Conversation
Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/256/coverage.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left some comments where the old "Should call all of the functions of child successfully" style was still used.
2af76ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @brapoprod !
This PR refactors the tests to be more streamlined and consistent. Also way more safe since we test towards what is send to the EditorAPI instead of just checking if the method has been called (in a lot of cases)
Related tickets
Screenshots