Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] [EDT-711] Add CornerRadius methods for shapes #267

Merged
merged 2 commits into from
Apr 19, 2023
Merged

[Feature] [EDT-711] Add CornerRadius methods for shapes #267

merged 2 commits into from
Apr 19, 2023

Conversation

evan-mcgeek
Copy link
Contributor

@evan-mcgeek evan-mcgeek commented Apr 11, 2023 •
edited
Loading

This PR:

  • added new methods to set corner radii for shapes
  • added new types related to corner radii
  • added new subscriber method to listen corner radii changes
  • shape related methods moved from FrameController to the new ShapeController, BUT the FrameController ones remain functional

Related tickets

@evan-mcgeek evan-mcgeek self-assigned this Apr 11, 2023
@github-actions
Copy link
Contributor

Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/267/coverage.html

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023 •
edited
Loading

Unit Test Results

    1 files    30 suites   36s ⏱️
249 tests 249 ✔️ 0 💤 0 ❌
250 runs  250 ✔️ 0 💤 0 ❌

Results for commit 9b8bea1.

♻️ This comment has been updated with latest results.

NicolaVerbeeck
NicolaVerbeeck approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@NicolaVerbeeck NicolaVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evan-mcgeek evan-mcgeek merged commit d9aa7d7 into main Apr 19, 2023
@evan-mcgeek evan-mcgeek deleted the feature/EDT-711-shape-corner-radius branch April 19, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brapoprod brapoprod brapoprod approved these changes

@pkgacek pkgacek pkgacek approved these changes

@NicolaVerbeeck NicolaVerbeeck NicolaVerbeeck approved these changes

@abdelhalimkhouas abdelhalimkhouas Awaiting requested review from abdelhalimkhouas

@alexandraFlavia9 alexandraFlavia9 Awaiting requested review from alexandraFlavia9

@pietervp pietervp Awaiting requested review from pietervp

@srares76 srares76 Awaiting requested review from srares76

Assignees

@evan-mcgeek evan-mcgeek

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evan-mcgeek @NicolaVerbeeck @pkgacek @brapoprod