-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] [EDT-1086] Improved get/set for Actions #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/331/coverage.html |
Matthiee
commented
Aug 24, 2023
Matthiee
requested review from
brapoprod,
abdelhalimkhouas,
alexandraFlavia9,
pietervp,
pkgacek and
srares76
as code owners
August 24, 2023 12:27
evan-mcgeek
reviewed
Aug 24, 2023
pietervp
previously approved these changes
Aug 30, 2023
Matthiee
commented
Sep 1, 2023
Dvergar
approved these changes
Sep 4, 2023
abdelhalimkhouas
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Action Typings with the engine changes.
Get properties
The getter properties on objects will now reflect the actual value vs snapshot value before.
Example:
Set methods
Setter methods have been added on studio objects as a shorthand for
studio.[controller].[setMethod]
.See PR for the full list of setter methods that have been added.
Example;
Improved argument types
In order to use actions more easily in advanced scenarios, the argument types for certain methods have been extended.
Example:
Example named objects:
Related tickets