Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [EDT-1089] Support setting image variable connector options #340

Merged
merged 13 commits into from
Sep 22, 2023

Conversation

Dvergar
Copy link
Contributor

@Dvergar Dvergar commented Sep 6, 2023

Related ticket: https://chilipublishintranet.atlassian.net/browse/EDT-1089


New SDK.variable methods:

SDK.variable.setImageVariableConnector now returns the new connector id.
SDK.variable.getImageVariableConnectorId has been added.
SDK.connector.getOptions has been added.
SDK.connector.getMappings has been added.

NOT a breaking-change

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/340/coverage.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Unit Test Results

    1 files    31 suites   27s ⏱️
277 tests 277 ✔️ 0 💤 0
278 runs  278 ✔️ 0 💤 0

Results for commit 3bcb81d.

♻️ This comment has been updated with latest results.

@Dvergar Dvergar changed the base branch from feature/connector-options-on-variable to main September 10, 2023 16:50
@Dvergar Dvergar changed the title [Feature] [WIP] Support setting image variable connector options [Feature] [EDT-1089] Support setting image variable connector options Sep 10, 2023
@Dvergar Dvergar marked this pull request as ready for review September 10, 2023 16:56
@Dvergar Dvergar self-assigned this Sep 10, 2023
@Dvergar Dvergar marked this pull request as draft September 11, 2023 07:22
@Dvergar Dvergar marked this pull request as ready for review September 11, 2023 15:21
@Dvergar Dvergar marked this pull request as draft September 11, 2023 15:21
@Dvergar Dvergar marked this pull request as ready for review September 13, 2023 11:59
@Dvergar Dvergar requested a review from Matthiee September 13, 2023 11:59
pietervp
pietervp previously approved these changes Sep 13, 2023
Matthiee
Matthiee previously approved these changes Sep 14, 2023
pkgacek
pkgacek previously approved these changes Sep 19, 2023
Copy link
Member

@brapoprod brapoprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dvergar Dvergar merged commit cafcf43 into main Sep 22, 2023
@Dvergar Dvergar deleted the feature/EDT-1089-get-set-variable-connector-2 branch September 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants