-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] [EDT-1089] Support setting image variable connector options #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report can be checked at https://chili-dev.azureedge.net/sdk/coverage/340/coverage.html |
Dvergar
changed the base branch from
feature/connector-options-on-variable
to
main
September 10, 2023 16:50
…to feature/EDT-1089-get-set-variable-connector-2
Dvergar
changed the title
[Feature] [WIP] Support setting image variable connector options
[Feature] [EDT-1089] Support setting image variable connector options
Sep 10, 2023
Dvergar
requested review from
brapoprod,
abdelhalimkhouas,
alexandraFlavia9,
pietervp,
pkgacek and
srares76
as code owners
September 10, 2023 16:56
…to feature/EDT-1089-get-set-variable-connector-2
…to feature/EDT-1089-get-set-variable-connector-2
pietervp
previously approved these changes
Sep 13, 2023
abdelhalimkhouas
previously approved these changes
Sep 14, 2023
Matthiee
previously approved these changes
Sep 14, 2023
pkgacek
previously approved these changes
Sep 19, 2023
…to feature/EDT-1089-get-set-variable-connector-2
Dvergar
dismissed stale reviews from pkgacek, Matthiee, abdelhalimkhouas, and pietervp
via
September 21, 2023 09:57
eeb4873
pietervp
reviewed
Sep 21, 2023
Matthiee
approved these changes
Sep 22, 2023
brapoprod
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://chilipublishintranet.atlassian.net/browse/EDT-1089
New
SDK.variable
methods:SDK.variable.setImageVariableConnector
now returns the new connector id.SDK.variable.getImageVariableConnectorId
has been added.SDK.connector.getOptions
has been added.SDK.connector.getMappings
has been added.NOT a breaking-change